[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0 v9 03/16] migration: remove unused &loca
From: |
fei |
Subject: |
Re: [Qemu-devel] [PATCH for-4.0 v9 03/16] migration: remove unused &local_err parameter in multifd_save_cleanup |
Date: |
Tue, 8 Jan 2019 23:58:54 +0800 |
> 在 2019年1月8日,00:50,Markus Armbruster <address@hidden> 写道:
>
> Fei Li <address@hidden> writes:
>
>> Always call migrate_set_error() to set the error state without relying
>> on whether multifd_save_cleanup() succeeds. As the passed &local_err
>> is never used in multifd_save_cleanup(), remove it. And make the
>> function be: void multifd_save_cleanup(void).
>>
>> Cc: Dr. David Alan Gilbert <address@hidden>
>> Signed-off-by: Fei Li <address@hidden>
>> Reviewed-by: Juan Quintela <address@hidden>
>
> The commit message is confusing. Suggest:
>
> migration: multifd_save_cleanup() can't fail, simplify
>
> multifd_save_cleanup() takes an Error ** argument and returns an
> error code even though it can't actually fail. Its callers
> dutifully check for failure. Remove the useless argument and return
> value, and simplify the callers.
Nice, thanks for the clearer comment. :)
Have a nice day
Fei
>
> I think multifd_load_cleanup() has exactly the same issue. Should we
> clean it up, too? Juan, what do you think?