Re: [Qemu-devel] [PATCH v5 0/8] linux-user: Split do_syscall

[Laurent Vivier]

On 19/12/2018 05:21, Richard Henderson wrote:
> Version 4 was back in August:
> https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg03745.html
> 
> Version 5 continues the file split via inclusion.  This incorporates
> Laurent's suggestion to have a "def" file that is included twice to
> generate both SyscallDef structures and fill in syscall_table's switch.
> 
> Again, this just converts a few syscalls as proof of concept.

This series breaks on all targets LTP tests: getgroups01, pwritev02,
pwritev02_64, and fixes: semop02.

It also breaks more tests only with arm target.

I will bisect and review...

Thanks,
Laurent

> 
> 
> r~
> 
> 
> Richard Henderson (8):
>   linux-user: Setup split syscall infrastructure
>   linux-user: Split out some simple file syscalls
>   linux-user: Reduce regpairs_aligned & target_offset64 ifdefs
>   linux-user: Split out preadv, pwritev, readv, writev, pread64,
>     pwrite64
>   linux-user: Split out name_to_handle_at, open_by_handle_at
>   linux-user: Split out ipc syscalls
>   linux-user: Split out memory syscalls
>   linux-user: Split out some process syscalls
> 
>  linux-user/syscall-defs.h     |  231 +++
>  linux-user/syscall.h          |   93 ++
>  linux-user/strace.c           |  567 ++++----
>  linux-user/syscall-file.inc.c |  638 +++++++++
>  linux-user/syscall-ipc.inc.c  | 1086 ++++++++++++++
>  linux-user/syscall-mem.inc.c  |  154 ++
>  linux-user/syscall-proc.inc.c |  861 ++++++++++++
>  linux-user/syscall.c          | 2500 ++-------------------------------
>  linux-user/strace.list        |  243 ----
>  9 files changed, 3499 insertions(+), 2874 deletions(-)
>  create mode 100644 linux-user/syscall-defs.h
>  create mode 100644 linux-user/syscall.h
>  create mode 100644 linux-user/syscall-file.inc.c
>  create mode 100644 linux-user/syscall-ipc.inc.c
>  create mode 100644 linux-user/syscall-mem.inc.c
>  create mode 100644 linux-user/syscall-proc.inc.c
>