Re: [Qemu-devel] [PULL 24/37] qtest: Add set_irq_in command to set IRQ/GPIO level

[Matthew Ogilvie]

On Mon, Jan 07, 2019 at 04:31:04PM +0000, Peter Maydell wrote:
> From: Steffen Görtz <address@hidden>
> 
> Adds a new qtest command "set_irq_in" which allows
> to set qemu gpio lines to a given level.
> 
> Based on https://lists.gnu.org/archive/html/qemu-devel/2012-12/msg02363.html
> which never got merged.
> 
> Signed-off-by: Steffen Görtz <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> Reviewed-by: Laurent Vivier <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Message-id: address@hidden
> Originally-by: Matthew Ogilvie <address@hidden>

It is kind of interesting to see a part of my old thread(s)
resurrected, even if it isn't the part I was actually interested
in.

Note that my miniinfo email account no longer exists, but I
can still be reached at address@hidden if desired.

Regarding the patch, I haven't kept up with changes to qemu
well enough to really have a useful opinion, although superficially
it looks good.  Perhaps it would make sense to include both
my old and new email addresses in the sign-off section, to both
tie it to the old threads and make it easier to reach me
if someone wants to contact me?  (But I'm not sure of a "clean"
way to do so, and it is probably low priority.  Perhaps this
current email is good enough?)

                - Matthew Ogilvie

P.S.: Explanation and keywords to find this message (and me) with
search tools:

With regards to qemu, my primary interest (from that thread and
related 2012 threads) is/was being able to run
"Microport UNIX System V/386 v2.1" (ca. 1987) under qemu, which
especially required:
   - Fixing various inaccuracies in qemu's model of the i8259
     interrupt controller.
   - Implementing very old graphics card model(s) that Microport UNIX
     actually knows how to control properly.  Perhaps original
     IBM monochrome display adaptor (MDA), CGA, and/or hercules
     graphics card.  Or else my nasty qemu hackish patches I wrote
     that allowed VGA to work in text mode despite Microport driving
     it like CGA in a way that didn't work with real VGA hardware.