[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID any
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore |
Date: |
Wed, 9 Jan 2019 19:51:54 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 09.01.2019 um 18:55 hat Eric Blake geschrieben:
> On 1/9/19 11:38 AM, Max Reitz wrote:
>
> >>>>> I do think it affects users of HMP, because right now you can delete
> >>>>> snapshots with their ID, and after this series you cannot.
> >>>>
>
> >> This. Is. HMP.
> >>
> >> Not a stable ABI, no deprecation period of two releases.
> >
> > Well, if you want to do it.
> >
> > This may be HMP, but this is also the only interface to savevm, so it's
> > not like users have a choice to use a more stable interface. I know
> > that was a conscious decision, more or less, but I don't see why we need
> > to be so nasty when the hardest thing about doing a nice deprecation
> > would be to remember to make it an error in half a year.
>
> Indeed, and libvirt IS using 'savevm' via HMP via QMP's
> human-monitor-command, since there is no QMP counterpart for internal
> snapshot. Even though lately we consistently tell people that internal
> snapshots are underdeveloped and you should use external snapshots, it
> does not get away from the fact that libvirt has been using 'savevm' to
> drive internal snapshots for years now, and that we MUST consider
> back-compat and/or add an introspectible QMP interface before making
> changes that would break libvirt.
Okay, so what does libvirt do when you request a snapshot with a
numerical name? Without having looked at the code, the best case I would
expect that it forbids them, and more realistically I suspect that we
may actually fix a bug for libvirt by changing the semantics.
Or does libvirt really use snapshot IDs rather than names?
Kevin
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, (continued)
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Daniel Henrique Barboza, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Max Reitz, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Max Reitz, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Eric Blake, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Max Reitz, 2019/01/11
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Eric Blake, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Eric Blake, 2019/01/09
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Dr. David Alan Gilbert, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Daniel Henrique Barboza, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Dr. David Alan Gilbert, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Eric Blake, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/11
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Max Reitz, 2019/01/11
- Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore, Kevin Wolf, 2019/01/11