[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table |
Date: |
Thu, 10 Jan 2019 07:33:45 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/10/19 3:42 AM, Leonid Bloch wrote:
> If you've noticed, the original script was in AWK. But to be as generic
> as possible, I didn't write the generation script in AWK because even
> AWK is not guaranteed to be installed on the build system. The only
> interpreted language that is guaranteed to be there is shell (most basic
> shell) because .configure itself needs it.
>
> Sure, the script could be prettier and shorter, but I wanted to keep it
> compatible with the most basic shell, not only Bash, and without needing
> external programs.
awk is portable - autoconf-generated scripts assume it exists (same as
sed, grep, ls, ...) if you have a /bin/sh. In fact, the GNU Coding
Standards has a nice list of programs that you can blindly assume exist.
It's true you may have to use a lowest-common-denominator when using
the tools that are globally available to be portable (not all awk
scripts are portable, even if awk is universally available on systems
with a Bourne-like shell). So avoiding awk on the grounds that it might
not be present is the wrong approach.
> Eric - thanks for the comment about 'local' - I will get rid of it if we
> decide to include this patch.
I'm still not convinced we need it. I would much rather see a patch
that makes QemuOpt accept default integer values as integers rather than
as strings, so we don't have to worry about stringifying special macros.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/1] include: Auto-generate the sizes lookup table, Leonid Bloch, 2019/01/03
- [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Leonid Bloch, 2019/01/03
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Markus Armbruster, 2019/01/08
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Eric Blake, 2019/01/08
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Leonid Bloch, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Markus Armbruster, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Leonid Bloch, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Markus Armbruster, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Eric Blake, 2019/01/10
Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Kevin Wolf, 2019/01/08
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Leonid Bloch, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Markus Armbruster, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Leonid Bloch, 2019/01/10
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Markus Armbruster, 2019/01/11
- Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Eric Blake, 2019/01/11
Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table, Alberto Garcia, 2019/01/10