[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] s390: avoid potential null dereference ins39
|
From: |
Cornelia Huck |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] s390: avoid potential null dereference ins390_pcihost_unplug() |
|
Date: |
Thu, 10 Jan 2019 16:18:47 +0100 |
On Tue, 8 Jan 2019 07:11:14 -0800
Li Qiang <address@hidden> wrote:
> When getting the 'pbdev', the if...else has no default branch.
> From Coverity, the 'pbdev' maybe null when the 'dev' is not
> the TYPE_PCI_BRIDGE/TYPE_PCI_DEVICE/TYPE_S390_PCI_DEVICE.
> This patch adds a default branch for device plug and unplug.
>
> Spotted by Coverity: CID 1398593
>
> Signed-off-by: Li Qiang <address@hidden>
> ---
>
> Change since v2: use g_assert_not_reached for default branch
>
> hw/s390x/s390-pci-bus.c | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks, applied.