Re: [Qemu-devel] [PATCH v1 05/19] tests: update Fedora i386 cross image to Fedora 29

[Philippe Mathieu-Daudé]

On 1/10/19 6:45 PM, Alex Bennée wrote:
> From: Daniel P. Berrangé <address@hidden>
> 
> Using the "latest" tag is not a good idea because this changes what
> release it points to every 6 months. Together with caching of docker
> builds this can cause confusion where CI has cached & built with Fedora
> N, while a developer tries to reproduce a CI problem with Fedora N + 1,
> or vica-verca.

So we now learned the hard way commiting "FROM x:latest" to a repository
is a bad practice.

> 
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  tests/docker/dockerfiles/fedora-i386-cross.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/fedora-i386-cross.docker 
> b/tests/docker/dockerfiles/fedora-i386-cross.docker
> index a4fd895b07..eb8108d118 100644
> --- a/tests/docker/dockerfiles/fedora-i386-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-i386-cross.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:latest

If checkpatch wasn't in Perl I'd have added a check to ban :latest.

> +FROM fedora:29
>  ENV PACKAGES \
>      gcc \
>      glib2-devel.i686 \
> 

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>