Re: [Qemu-devel] [PATCH v1 05/19] tests: update Fedora i386 cross image to Fedora 29

[Daniel P . Berrangé]

On Thu, Jan 10, 2019 at 06:54:24PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/10/19 6:45 PM, Alex Bennée wrote:
> > From: Daniel P. Berrangé <address@hidden>
> > 
> > Using the "latest" tag is not a good idea because this changes what
> > release it points to every 6 months. Together with caching of docker
> > builds this can cause confusion where CI has cached & built with Fedora
> > N, while a developer tries to reproduce a CI problem with Fedora N + 1,
> > or vica-verca.
> 
> So we now learned the hard way commiting "FROM x:latest" to a repository
> is a bad practice.

Unfortunately this is the second time we've had to learn it :-(

  commit 5b9b49d7bd3e0da13e8f6d58578443a11817f56e
  Author: Paolo Bonzini <address@hidden>
  Date:   Fri Jan 12 12:11:43 2018 +0100

    docker: change Fedora base image to fedora:27
    
    Using "fedora:latest" makes behavior different depending on when you
    actually pulled the image from the docker repository.  In my case,
    the supposedly "latest" image was a Fedora 25 download from 8 months
    ago, and the new "test-debug" test was failing.
    
    Use "27" to improve reproducibility and make it clear when the image
    is obsolete.
    

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|