[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 08/21] migration: introduce icount field for
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v9 08/21] migration: introduce icount field for snapshots |
Date: |
Fri, 11 Jan 2019 09:01:11 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Pavel Dovgalyuk <address@hidden> writes:
> Saving icount as a parameters of the snapshot allows navigation between
> them in the execution replay scenario.
> This information can be used for finding a specific snapshot for rewinding
> the recorded execution to the specific moment of the time.
> E.g., 'reverse step' action needs to load the nearest snapshot which is
> prior to the current moment of time .
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
>
> --
>
> v2:
> - made icount in SnapshotInfo optional (suggested by Eric Blake)
> v7:
> - added more comments for icount member (suggested by Markus Armbruster)
> v9:
> - updated icount comment
> ---
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 762000f..a197e5f 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -26,13 +26,19 @@
> #
> # @vm-clock-nsec: fractional part in nano seconds to be used with
> vm-clock-sec
> #
> +# @icount: Current instruction count. Appears when execution record/replay
> +# is enabled. Used for "time-traveling" to match the moment
> +# in the recorded execution with the snapshots. This counter may
> +# be obtained through @query-replay command (since 4.0)
query-replay appears only in PATCH 11. Please delay the last sentence
until then.
> +#
> # Since: 1.3
> #
> ##
> { 'struct': 'SnapshotInfo',
> 'data': { 'id': 'str', 'name': 'str', 'vm-state-size': 'int',
> 'date-sec': 'int', 'date-nsec': 'int',
> - 'vm-clock-sec': 'int', 'vm-clock-nsec': 'int' } }
> + 'vm-clock-sec': 'int', 'vm-clock-nsec': 'int',
> + '*icount': 'int' } }
>
> ##
> # @ImageInfoSpecificQCow2EncryptionBase:
> diff --git a/qapi/block.json b/qapi/block.json
> index 11f01f2..a6396a9 100644
> --- a/qapi/block.json
> +++ b/qapi/block.json
> @@ -176,7 +176,8 @@
> # "date-sec": 1000012,
> # "date-nsec": 10,
> # "vm-clock-sec": 100,
> -# "vm-clock-nsec": 20
> +# "vm-clock-nsec": 20,
> +# "icount": 220414
> # }
> # }
> #
- [Qemu-devel] [PATCH v9 00/21] Fixing record/replay and adding reverse debugging, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 02/21] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 01/21] replay: add missing fix for internal function, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 03/21] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 04/21] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 05/21] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 06/21] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 07/21] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 08/21] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2019/01/09
- Re: [Qemu-devel] [PATCH v9 08/21] migration: introduce icount field for snapshots,
Markus Armbruster <=
- [Qemu-devel] [PATCH v9 09/21] replay: provide and accessor for rr filename, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 10/21] qapi: introduce replay.json for record/replay-related stuff, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 11/21] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2019/01/09
- [Qemu-devel] [PATCH v9 12/21] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2019/01/09