[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 3/4] i386: import & use bootparam.h

From: Li Zhijian
Subject: Re: [Qemu-devel] [PATCH v5 3/4] i386: import & use bootparam.h
Date: Fri, 11 Jan 2019 18:03:41 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

Hi Stefano

On 1/11/19 17:48, Stefano Garzarella wrote:
Hi Li,

On Fri, Jan 11, 2019 at 10:06 AM Li Zhijian <address@hidden> wrote:
+        # unnecessary import of several video/ist/etc headers
+        sed -e '/__ASSEMBLY__/,/__ASSEMBLY__/d' $tmpdir/include/asm/bootparam.h 
> $tmpdir/bootparam.h
+        cp_portable $tmpdir/bootparam.h 
Maybe you miss my comment. Anyway, IMHO is better to use the double
quotes for all paths.

Reviewed-by: Stefano Garzarella <address@hidden>

So sorry about it, i folded it on a wrong branch at the beginning.

will update it soon.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]