Re: [Qemu-devel] [PATCH v3 2/2] virtio: Make disable-legacy/disable-modern compat properties optional

[Cornelia Huck]

On Thu, 10 Jan 2019 16:04:58 -0200
Eduardo Habkost <address@hidden> wrote:

> The disable-legacy and disable-modern properties apply only to
> some virtio-pci devices.  Make those properties optional.
> 
> This fixes the crash introduced by commit f6e501a28ef9 ("virtio: Provide
> version-specific variants of virtio PCI devices"):
> 
>   $ qemu-system-x86_64 -machine pc-i440fx-2.6 \
>     -device virtio-net-pci-non-transitional
>   Unexpected error in object_property_find() at qom/object.c:1092:
>   qemu-system-x86_64: -device virtio-net-pci-non-transitional: can't apply \
>   global virtio-pci.disable-modern=on: Property '.disable-modern' not found
>   Aborted (core dumped)
> 
> Reported-by: Thomas Huth <address@hidden>
> Fixes: f6e501a28ef9 ("virtio: Provide version-specific variants of virtio PCI 
> devices")
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  hw/core/machine.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Cornelia Huck <address@hidden>