[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target/xtensa: rework zero overhead loops im
Re: [Qemu-devel] [PATCH v2] target/xtensa: rework zero overhead loops implementation
Sat, 12 Jan 2019 09:17:08 +1100
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1
On 1/12/19 9:14 AM, Max Filippov wrote:
>>> + /*
>>> + * 0 in the csbase_lend field means that there may not be a
>>> + * for any instruction that starts inside this page. Any other
>>> + * means that an instruction that ends at this offset from the page
>>> + * start may loop back.
>> Nit: s/may/will/g
>> Using "may" makes it seem like we may have missed a case that should have
>> looped back.
> Using "will" makes it seem like it always loops back, but it doesn't do it
> when LCOUNT is 0.
Err, no, you covered that in the first sentence, where 0 means that it will not