[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler. |
Date: |
Sat, 12 Jan 2019 08:30:08 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Dec 20, 2018 at 04:20:28PM +0100, address@hidden wrote:
> From: Remy Noel <address@hidden>
>
> It is possible for an io_poll/read/write callback to be concurrently executed
> along
> with an aio_set_fd_handlers. This can cause all sorts of problems, like
> a NULL callback or a bad opaque pointer.
>
> V2:
> * Do not use RCU anymore as it inccurs a performance loss
> V3:
> * Don't drop revents when a handler is modified [Stefan]
> V4:
> * Unregister fd from ctx epoll when removing fd_handler [Paolo]
>
> Remy Noel (2):
> aio-posix: Unregister fd from ctx epoll when removing fd_handler.
> aio-posix: Fix concurrent aio_poll/set_fd_handler.
>
> util/aio-posix.c | 90 +++++++++++++++++++++++++++++-------------------
> util/aio-win32.c | 67 ++++++++++++++++-------------------
> 2 files changed, 84 insertions(+), 73 deletions(-)
>
> --
> 2.19.2
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature