|
From: | Marcel Apfelbaum |
Subject: | Re: [Qemu-devel] [PATCH PULL 02/31] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer |
Date: | Sat, 12 Jan 2019 11:46:00 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 1/8/19 11:18 AM, Cornelia Huck wrote:
On Tue, 8 Jan 2019 10:41:38 +0200 Marcel Apfelbaum <address@hidden> wrote:On 1/7/19 7:54 PM, Cornelia Huck wrote:On Mon, 7 Jan 2019 19:28:10 +0200 Marcel Apfelbaum <address@hidden> wrote:On 1/3/19 12:34 PM, Cornelia Huck wrote:clang-6.0: error: -libumad: 'linker' input unused [-Werror,-Wunused-command-line-argument]Is really strange, the rdma-mux is part of the contrib directory and is not even compiled by default.Explicitly passing --disable-pvrdma to configure disables the offending code. Let me know if you need more information.Can you please send the exact steps you are using to configure and compile QEMU, are you compiling on a x86 machine?Yes, this is on my laptop (up-to-date F28). I can reproduce on current master, configured with ../configure --target-list="s390x-softmmu s390x-linux-user i386-softmmu x86_64-softmmu cris-softmmu arm-softmmu ppc64-softmmu" --enable-linux-aio --enable-virtfs --enable-trace-backends=simple --cc=clang --enable-rdma --enable-pvrdma It compiles if I pass --disable-pvrdma instead. It also compiles if I drop --cc=clang. I'm building in a build subdirectory; I have already tried purging it before rebuilding, without luck. clang --version says clang version 6.0.1 (tags/RELEASE_601/final) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /usr/binThanks for the information, I will look into it. MarcelThanks. Another data point: I see the same on a Fedora 29 on s390x, so this does not seem to be a broken local setup (unless I managed to mess up both systems in the same way...) clang --version says clang version 7.0.0 (Fedora 7.0.0-2.fc29) Target: s390x-ibm-linux Thread model: posix InstalledDir: /usr/bin
Hi Cornelia, I reproduced the issue and found the root cause: contrib/rdmacm-mux/Makefile.objs: ifdef CONFIG_PVRDMA CFLAGS += -libumad -Wno-format-truncation rdmacm-mux-obj-y = main.o endifThe above file adds libumad dependency for all project targets even if not needed.
Gcc allows that while clang forbids it. (is strange it passed patchew tests) I will come up with a fix soon. Thanks, Marcel
[Prev in Thread] | Current Thread | [Next in Thread] |