[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui: vnc: finish removing TABs
|
From: |
no-reply |
|
Subject: |
Re: [Qemu-devel] [PATCH] ui: vnc: finish removing TABs |
|
Date: |
Sun, 13 Jan 2019 09:19:05 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] ui: vnc: finish removing TABs
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
21e3281 ui: vnc: finish removing TABs
=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#66: FILE: ui/vnc-enc-hextile-template.h:49:
+ if (irow[i] == bg)
[...]
+ else if (irow[i] == fg)
[...]
ERROR: braces {} are necessary for all arms of this statement
#68: FILE: ui/vnc-enc-hextile-template.h:51:
+ else if (irow[i] == fg)
[...]
ERROR: braces {} are necessary for all arms of this statement
#76: FILE: ui/vnc-enc-hextile-template.h:59:
+ if (n_colors > 2)
[...]
ERROR: braces {} are necessary for all arms of this statement
#146: FILE: ui/vnc-enc-hextile-template.h:95:
+ if (min_x == -1)
[...]
ERROR: braces {} are necessary for all arms of this statement
#172: FILE: ui/vnc-enc-hextile-template.h:117:
+ if (!*has_bg || *last_bg != bg)
[...]
ERROR: braces {} are necessary for all arms of this statement
#195: FILE: ui/vnc-enc-hextile-template.h:127:
+ if (irow[i] == bg)
[...]
WARNING: Block comments use a leading /* on a separate line
#271: FILE: ui/vnc-enc-hextile-template.h:175:
+ /* we really don't have to invalidate either the bg or fg
WARNING: Block comments use * on subsequent lines
#272: FILE: ui/vnc-enc-hextile-template.h:176:
+ /* we really don't have to invalidate either the bg or fg
+ but we've lost the old values. oh well. */
WARNING: Block comments use a trailing */ on a separate line
#272: FILE: ui/vnc-enc-hextile-template.h:176:
+ but we've lost the old values. oh well. */
ERROR: braces {} are necessary for all arms of this statement
#301: FILE: ui/vnc-enc-hextile-template.h:192:
+ if (flags & 0x02)
[...]
ERROR: braces {} are necessary for all arms of this statement
#303: FILE: ui/vnc-enc-hextile-template.h:194:
+ if (flags & 0x04)
[...]
WARNING: Block comments use a trailing */ on a separate line
#339: FILE: ui/vnc-enc-zywrle.h:56:
+ {0x0000FF00, 0x00FFFFFF, 0x00FFFFFF}, */
ERROR: "(foo*)" should be "(foo *)"
#630: FILE: ui/vnc-enc-zywrle.h:217:
+ r = (((uint8_t*)src)[S_1]<< 1)& 0xF8; \
ERROR: spaces required around that '<<' (ctx:VxW)
#630: FILE: ui/vnc-enc-zywrle.h:217:
+ r = (((uint8_t*)src)[S_1]<< 1)& 0xF8; \
^
ERROR: spaces required around that '&' (ctx:VxW)
#630: FILE: ui/vnc-enc-zywrle.h:217:
+ r = (((uint8_t*)src)[S_1]<< 1)& 0xF8; \
^
ERROR: "(foo*)" should be "(foo *)"
#631: FILE: ui/vnc-enc-zywrle.h:218:
+ g = (((uint8_t*)src)[S_1]<< 6) | (((uint8_t*)src)[S_0]>> 2); \
ERROR: spaces required around that '<<' (ctx:VxW)
#631: FILE: ui/vnc-enc-zywrle.h:218:
+ g = (((uint8_t*)src)[S_1]<< 6) | (((uint8_t*)src)[S_0]>> 2); \
^
ERROR: spaces required around that '>>' (ctx:VxW)
#631: FILE: ui/vnc-enc-zywrle.h:218:
+ g = (((uint8_t*)src)[S_1]<< 6) | (((uint8_t*)src)[S_0]>> 2); \
^
ERROR: "(foo*)" should be "(foo *)"
#634: FILE: ui/vnc-enc-zywrle.h:220:
+ b = (((uint8_t*)src)[S_0]<< 3)& 0xF8; \
ERROR: spaces required around that '<<' (ctx:VxW)
#634: FILE: ui/vnc-enc-zywrle.h:220:
+ b = (((uint8_t*)src)[S_0]<< 3)& 0xF8; \
^
ERROR: spaces required around that '&' (ctx:VxW)
#634: FILE: ui/vnc-enc-zywrle.h:220:
+ b = (((uint8_t*)src)[S_0]<< 3)& 0xF8; \
^
ERROR: "(foo*)" should be "(foo *)"
#647: FILE: ui/vnc-enc-zywrle.h:228:
+ ((uint8_t*)dst)[S_1] = (uint8_t)((r >> 1)|(g >> 6)); \
ERROR: spaces required around that '|' (ctx:VxV)
#647: FILE: ui/vnc-enc-zywrle.h:228:
+ ((uint8_t*)dst)[S_1] = (uint8_t)((r >> 1)|(g >> 6)); \
^
ERROR: "(foo*)" should be "(foo *)"
#648: FILE: ui/vnc-enc-zywrle.h:229:
+ ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 2))& 0xFF); \
ERROR: spaces required around that '|' (ctx:VxV)
#648: FILE: ui/vnc-enc-zywrle.h:229:
+ ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 2))& 0xFF); \
^
ERROR: spaces required around that '&' (ctx:VxW)
#648: FILE: ui/vnc-enc-zywrle.h:229:
+ ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 2))& 0xFF); \
^
ERROR: "(foo*)" should be "(foo *)"
#657: FILE: ui/vnc-enc-zywrle.h:236:
+ r = ((uint8_t*)src)[S_1] & 0xF8; \
ERROR: "(foo*)" should be "(foo *)"
#658: FILE: ui/vnc-enc-zywrle.h:237:
+ g = (((uint8_t*)src)[S_1]<< 5) | (((uint8_t*)src)[S_0] >> 3); \
ERROR: spaces required around that '<<' (ctx:VxW)
#658: FILE: ui/vnc-enc-zywrle.h:237:
+ g = (((uint8_t*)src)[S_1]<< 5) | (((uint8_t*)src)[S_0] >> 3); \
^
ERROR: "(foo*)" should be "(foo *)"
#661: FILE: ui/vnc-enc-zywrle.h:239:
+ b = (((uint8_t*)src)[S_0]<< 3) & 0xF8; \
ERROR: spaces required around that '<<' (ctx:VxW)
#661: FILE: ui/vnc-enc-zywrle.h:239:
+ b = (((uint8_t*)src)[S_0]<< 3) & 0xF8; \
^
ERROR: "(foo*)" should be "(foo *)"
#674: FILE: ui/vnc-enc-zywrle.h:247:
+ ((uint8_t*)dst)[S_1] = (uint8_t)(r | (g >> 5)); \
ERROR: "(foo*)" should be "(foo *)"
#675: FILE: ui/vnc-enc-zywrle.h:248:
+ ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 3)) & 0xFF); \
ERROR: spaces required around that '|' (ctx:VxV)
#675: FILE: ui/vnc-enc-zywrle.h:248:
+ ((uint8_t*)dst)[S_0] = (uint8_t)(((b >> 3)|(g << 3)) & 0xFF); \
^
ERROR: "(foo*)" should be "(foo *)"
#685: FILE: ui/vnc-enc-zywrle.h:255:
+ r = ((uint8_t*)src)[L_2]; \
ERROR: "(foo*)" should be "(foo *)"
#686: FILE: ui/vnc-enc-zywrle.h:256:
+ g = ((uint8_t*)src)[L_1]; \
ERROR: "(foo*)" should be "(foo *)"
#687: FILE: ui/vnc-enc-zywrle.h:257:
+ b = ((uint8_t*)src)[L_0]; \
ERROR: "(foo*)" should be "(foo *)"
#694: FILE: ui/vnc-enc-zywrle.h:261:
+ ((uint8_t*)dst)[L_2] = (uint8_t)r; \
ERROR: "(foo*)" should be "(foo *)"
#695: FILE: ui/vnc-enc-zywrle.h:262:
+ ((uint8_t*)dst)[L_1] = (uint8_t)g; \
ERROR: "(foo*)" should be "(foo *)"
#696: FILE: ui/vnc-enc-zywrle.h:263:
+ ((uint8_t*)dst)[L_0] = (uint8_t)b; \
ERROR: spaces required around that '<<' (ctx:VxV)
#738: FILE: ui/vnc-enc-zywrle.h:460:
+ s = 1<<l;
^
ERROR: "(foo*)" should be "(foo *)"
#755: FILE: ui/vnc-enc-zywrle.h:474:
+ r = ((int8_t*)src)[2]; \
ERROR: "(foo*)" should be "(foo *)"
#756: FILE: ui/vnc-enc-zywrle.h:475:
+ g = ((int8_t*)src)[1]; \
ERROR: "(foo*)" should be "(foo *)"
#757: FILE: ui/vnc-enc-zywrle.h:476:
+ b = ((int8_t*)src)[0]; \
ERROR: "(foo*)" should be "(foo *)"
#765: FILE: ui/vnc-enc-zywrle.h:481:
+ ((int8_t*)dst)[2] = (int8_t)r; \
ERROR: "(foo*)" should be "(foo *)"
#766: FILE: ui/vnc-enc-zywrle.h:482:
+ ((int8_t*)dst)[1] = (int8_t)g; \
ERROR: "(foo*)" should be "(foo *)"
#767: FILE: ui/vnc-enc-zywrle.h:483:
+ ((int8_t*)dst)[0] = (int8_t)b; \
total: 43 errors, 4 warnings, 778 lines checked
Commit 21e3281c3b64 (ui: vnc: finish removing TABs) has style problems, please
review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden