[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] vfio/display: add edid support.
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] vfio/display: add edid support. |
Date: |
Sun, 13 Jan 2019 09:12:57 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 0/5] vfio/display: add edid support.
Type: series
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d3b83e9 some logging
46b3123 vfio/display: delay link up event
6ae7726 vfio/display: add xres + yres properties
d8234fb vfio/display: add edid support.
45e1bc1 vfio: update kernel headers.
=== OUTPUT BEGIN ===
1/5 Checking commit 45e1bc16552c (vfio: update kernel headers.)
2/5 Checking commit d8234fb5723c (vfio/display: add edid support.)
ERROR: line over 90 characters
#44: FILE: hw/vfio/display.c:40:
+static void vfio_display_edid_update(VFIOPCIDevice *vdev, bool enabled, int
prefx, int prefy)
WARNING: line over 80 characters
#122: FILE: hw/vfio/display.c:118:
+ pread_field(vdev->vbasedev.fd, dpy->edid_info, dpy->edid_regs,
edid_max_size);
ERROR: braces {} are necessary for all arms of this statement
#139: FILE: hw/vfio/display.c:135:
+ if (!dpy->edid_regs)
[...]
total: 2 errors, 1 warnings, 156 lines checked
Patch 2/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/5 Checking commit 6ae77261d5f3 (vfio/display: add xres + yres properties)
ERROR: braces {} are necessary for all arms of this statement
#34: FILE: hw/vfio/display.c:124:
+ if (!vdev->display_xres)
[...]
ERROR: braces {} are necessary for all arms of this statement
#36: FILE: hw/vfio/display.c:126:
+ if (!vdev->display_yres)
[...]
total: 2 errors, 0 warnings, 38 lines checked
Patch 3/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit 46b312391ae4 (vfio/display: delay link up event)
WARNING: line over 80 characters
#51: FILE: hw/vfio/display.c:89:
+ timer_mod(dpy->edid_link_timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME) +
100);
total: 0 errors, 1 warnings, 59 lines checked
Patch 4/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/5 Checking commit d3b83e9d78a1 (some logging)
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 46 lines checked
Patch 5/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 0/5] vfio/display: add edid support., Gerd Hoffmann, 2019/01/11
- [Qemu-devel] [PATCH 4/5] vfio/display: delay link up event, Gerd Hoffmann, 2019/01/11
- [Qemu-devel] [PATCH 3/5] vfio/display: add xres + yres properties, Gerd Hoffmann, 2019/01/11
- [Qemu-devel] [PATCH 2/5] vfio/display: add edid support., Gerd Hoffmann, 2019/01/11
- [Qemu-devel] [PATCH 1/5] vfio: update kernel headers., Gerd Hoffmann, 2019/01/11
- [Qemu-devel] [PATCH 5/5] [debug] some logging, Gerd Hoffmann, 2019/01/11
- Re: [Qemu-devel] [PATCH 0/5] vfio/display: add edid support.,
no-reply <=