[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsyste
Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type
Mon, 14 Jan 2019 08:59:22 +0300
> From: Paolo Bonzini [mailto:address@hidden
> On 10/01/19 14:30, Pavel Dovgalyuk wrote:
> > Now timerlist_deadline_ns uses all virtual timers for deadline calculation
> > (including
> > ones).
> > qemu_start_warp_timer uses the deadline for setting warp timer (which
> > should be
> Can you introduce a variant of qemu_clock_deadline_ns_all that ignores
> external timers, and use it in qemu_start_warp_timer?
> timerlist_deadline_ns can be made static, so adding a bool argument to
> it is not a big issue for API cleanliness.
> In fact, qemu_clock_deadline_ns_all is only ever used with
> QEMU_CLOCK_VIRTUAL, so you could also change it to
> uint64_t virtual_clock_deadline_ns(bool include_external);
I started making changes and it seems that this parameter should never be true,
because this function is called either from cpus.c or from the tests.