[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_unini
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit() |
Date: |
Mon, 14 Jan 2019 08:02:23 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Peter Xu <address@hidden> writes:
> On Sun, Jan 13, 2019 at 10:36:41PM +0800, Fei Li wrote:
>> From: Fei Li <address@hidden>
>>
>> Let's supplement the msi_uninit() when failing to realize
>> the pci edu device.
>>
>> Cc: Markus Armbruster <address@hidden>
>> Cc: Peter Xu <address@hidden>
>> Cc: Michael S. Tsirkin <address@hidden>
>> Cc: Marcel Apfelbaum <address@hidden>
>> Signed-off-by: Fei Li <address@hidden>
>> ---
>> hw/misc/edu.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
>> index cdcf550dd7..4feb7503de 100644
>> --- a/hw/misc/edu.c
>> +++ b/hw/misc/edu.c
>> @@ -367,6 +367,7 @@ static void pci_edu_uninit(PCIDevice *pdev)
>> {
>> EduState *edu = EDU(pdev);
>>
>> + msi_uninit(pdev);
>
> It would be cleaner to me to call this after the join() since
> edu_fact_thread() could potentially use msi_*() helpers then the
> destructions follow the reverse order of init.
Destruction in reverse creation order is good practice.
This being the "QEMU educational PCI device", good practice is even more
desirable.
> Reviewed-by: Peter Xu <address@hidden>
>
>> qemu_mutex_lock(&edu->thr_mutex);
>> edu->stopping = true;
>> qemu_mutex_unlock(&edu->thr_mutex);
>> --
>> 2.17.2 (Apple Git-113)
>>
>
> Regards,