[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/misc/edu: add msi_uninit() for pci_edu_un
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/misc/edu: add msi_uninit() for pci_edu_uninit() |
Date: |
Mon, 14 Jan 2019 14:28:39 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
Cc'ing qemu-trivial
On 1/14/19 2:10 PM, Fei Li wrote:
> From: Fei Li <address@hidden>
>
> Let's supplement the msi_uninit() when failing to realize
> the pci edu device.
>
> Reported-by: Markus Armbruster <address@hidden>
> Signed-off-by: Fei Li <address@hidden>
> Reviewed-by: Marcel Apfelbaum <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Peter Xu <address@hidden>
> ---
> hw/misc/edu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index cdcf550dd7..ceaf688bfb 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -377,6 +377,7 @@ static void pci_edu_uninit(PCIDevice *pdev)
> qemu_mutex_destroy(&edu->thr_mutex);
>
> timer_del(&edu->dma_timer);
> + msi_uninit(pdev);
> }
>
> static void edu_obj_uint64(Object *obj, Visitor *v, const char *name,
>