qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH] tests: use g_usleep instead of rem = sleep(


From: Peter Maydell
Subject: Re: [Qemu-devel] [RFC PATCH] tests: use g_usleep instead of rem = sleep(time)
Date: Mon, 14 Jan 2019 13:50:50 +0000

On Mon, 14 Jan 2019 at 11:07, Alex Bennée <address@hidden> wrote:
>
> Relying on sleep to always return having slept isn't safe as a signal
> may have occurred. If signals are constantly incoming the program will
> never reach it's termination condition. This is believed to be the
> mechanism causing time outs for qht-test in Travis.
>
> The glib g_usleep() deals with all of this for us so lets use it instead.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  tests/atomic64-bench.c   | 6 ++----
>  tests/atomic_add-bench.c | 6 ++----
>  tests/qht-bench.c        | 6 ++----
>  3 files changed, 6 insertions(+), 12 deletions(-)

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]