[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net/colo-compare.c: Remove duplicated code
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] net/colo-compare.c: Remove duplicated code |
Date: |
Mon, 14 Jan 2019 15:30:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-14 15:05, Zhang Chen wrote:
> From: Zhang Chen <address@hidden>
>
> Fix duplicated code:
> https://bugs.launchpad.net/qemu/+bug/1811499
>
> Signed-off-by: Zhang Chen <address@hidden>
> ---
> net/colo-compare.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index 9156ab3349..fa3fd0632d 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -285,14 +285,6 @@ static bool colo_mark_tcp_pkt(Packet *ppkt, Packet *spkt,
> {
> *mark = 0;
>
> - if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) {
> - if (colo_compare_packet_payload(ppkt, spkt,
> - ppkt->header_size, spkt->header_size,
> - ppkt->payload_size)) {
> - *mark = COLO_COMPARE_FREE_SECONDARY | COLO_COMPARE_FREE_PRIMARY;
> - return true;
> - }
> - }
> if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) {
> if (colo_compare_packet_payload(ppkt, spkt,
> ppkt->header_size, spkt->header_size,
>
Reviewed-by: Thomas Huth <address@hidden>