qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode
Date: Mon, 14 Jan 2019 16:37:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2019-01-14 16:23, Thomas Huth wrote:
> On 2019-01-14 16:02, Eric Blake wrote:
>> On 1/14/19 8:53 AM, Thomas Huth wrote:
[...]
>>> The patch is only changing libiscsi_cflags, so it's not affecting the
>>> entire project, but just the files that use libiscsi.
>>
>> Even so, limiting the damage to just the wrapper file that includes the
>> problematic header rather than changing the command line for the entire
>> compilation of those files that use libiscsi is even more precise.
> 
> Then our only option is "#define inline /* nothing */", as far as I can
> see...

Or this one, which seems to be a better idea to me:

#define inline __attribute__((gnu_inline))

gnu_inline should give the same behavior like the "inline" keywords in
gnu89 mode.

 Thomas

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]