[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/8] nbd: Add some error case testing to iote

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 1/8] nbd: Add some error case testing to iotests 223
Date: Mon, 14 Jan 2019 09:42:34 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/14/19 2:25 AM, Vladimir Sementsov-Ogievskiy wrote:
> 11.01.2019 22:47, Eric Blake wrote:
>> Testing success paths is important, but it's also nice to highlight
>> expected failure handling, to show that we don't crash, and so that
>> upcoming tests that change behavior can demonstrate the resulting
>> effects on error paths.
>> Add the following errors:
>> Attempting to export without a running server
>> Attempting to start a second server
>> Attempting to export a bad node name
>> Attempting to export a name that is already exported
>> Attempting to export an enabled bitmap
>> Attempting to clean an already cleaned export
> For me "clean" sounds not the same as "remove" (I used to the thought that
> remove means to remove object from larger object, and clean is clean the
> object internally (remove its content?), but it continues to exist and all
> its relations with parents are not touched), but I'm really far from being
> an expert in English.

Sure, I'll s/clean/remove/ in that text.

>> Attempting to quit server a second time
>> All of these properly complain except for a second server-stop,
>> which will be fixed next.
> hm, looks a bit strange to add test first and then fix bug, but on the
> other hand it's more demonstrative, OK for me.
>> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]