[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 34/44] globals: Allow global properties to be optiona
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 34/44] globals: Allow global properties to be optional |
Date: |
Mon, 14 Jan 2019 20:36:47 -0500 |
From: Eduardo Habkost <address@hidden>
Making some global properties optional will let us simplify
compat code when a given property works on most (but not all)
subclasses of a given type.
Device types will be able to opt out from optional compat
properties by simply not registering those properties.
Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
include/hw/qdev-core.h | 3 +++
qom/object.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 9614f76ae6..0a84c42756 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -250,6 +250,8 @@ struct PropertyInfo {
/**
* GlobalProperty:
* @used: Set to true if property was used when initializing a device.
+ * @optional: If set to true, GlobalProperty will be skipped without errors
+ * if the property doesn't exist.
*
* An error is fatal for non-hotplugged devices, when the global is applied.
*/
@@ -258,6 +260,7 @@ typedef struct GlobalProperty {
const char *property;
const char *value;
bool used;
+ bool optional;
} GlobalProperty;
static inline void
diff --git a/qom/object.c b/qom/object.c
index 4e5226ca12..b8c732063b 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -385,6 +385,9 @@ void object_apply_global_props(Object *obj, const GPtrArray
*props, Error **errp
if (object_dynamic_cast(obj, p->driver) == NULL) {
continue;
}
+ if (p->optional && !object_property_find(obj, p->property, NULL)) {
+ continue;
+ }
p->used = true;
object_property_parse(obj, p->value, p->property, &err);
if (err != NULL) {
--
MST
- [Qemu-devel] [PULL 00/44] pci, pc, virtio: fixes, features, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 44/44] acpi: update expected files, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 43/44] hw: acpi: Fix memory hotplug AML generation error, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 42/44] tpm: clear RAM when "memory overwrite" requested, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 41/44] acpi: add ACPI memory clear interface, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 40/44] acpi: build TPM Physical Presence interface, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 39/44] acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 38/44] tpm: allocate/map buffer for TPM Physical Presence interface, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 36/44] hw/misc/edu: add msi_uninit() for pci_edu_uninit(), Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 37/44] tpm: add a "ppi" boolean property, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 34/44] globals: Allow global properties to be optional,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 33/44] virtio: virtio 9p really requires CONFIG_VIRTFS to work, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 29/44] virtio: split virtio net bits from virtio-pci, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 25/44] virtio: split vhost user scsi bits from virtio-pci, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 24/44] virtio: split vhost user blk bits from virtio-pci, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 35/44] virtio: Make disable-legacy/disable-modern compat properties optional, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 32/44] virtio: split virtio crypto bits from virtio-pci.h, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 31/44] virtio: split virtio gpu bits from virtio-pci.h, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 20/44] virtio: split virtio input bits from virtio-pci, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 19/44] virtio: split virtio input host bits from virtio-pci, Michael S. Tsirkin, 2019/01/14
- [Qemu-devel] [PULL 18/44] virtio: split vhost vsock bits from virtio-pci, Michael S. Tsirkin, 2019/01/14