Re: [Qemu-devel] [PATCH v1 1/5] cpu: introduce die, the new cpu toppolgy emulation level

[Xu, Like]

> -----Original Message-----
> From: Eric Blake [mailto:address@hidden
> Sent: Tuesday, January 15, 2019 4:08 AM
> To: Like Xu <address@hidden>; address@hidden
> Cc: address@hidden; Peter Crosthwaite
> <address@hidden>; Eduardo Habkost <address@hidden>;
> Michael S. Tsirkin <address@hidden>; Xu, Like <address@hidden>;
> Marcelo Tosatti <address@hidden>; Paolo Bonzini
> <address@hidden>; address@hidden; Richard Henderson
> <address@hidden>
> Subject: Re: [Qemu-devel] [PATCH v1 1/5] cpu: introduce die, the new cpu
> toppolgy emulation level
> 
> On 1/14/19 6:24 AM, Like Xu wrote:
> > Following codes on smp_cores, the smp_dies/nr_dies/die-id is added to
> > machine and CPUState. In addition to enable_cpuid_0xb,
> enable_cpuid_0x1f
> > is introduced to track wether host is a new MCP macine or just ignored.
> 
> s/wether/whether/, s/macine/machine/
[Xu, Like] Sorry for typos and inconvenience.
> 
> > The number for die level_type on Intel is 5 while core type keeps 2.
> >
> > Signed-off-by: Like Xu <address@hidden>
> > ---
> >  cpus.c                | 1 +
> >  include/qom/cpu.h     | 1 +
> >  include/sysemu/cpus.h | 1 +
> >  qapi/misc.json        | 1 +
> >  target/i386/cpu.h     | 5 +++++
> >  5 files changed, 9 insertions(+)
> >
> 
> > +++ b/qapi/misc.json
> > @@ -3229,6 +3229,7 @@
> >  { 'struct': 'CpuInstanceProperties',
> >    'data': { '*node-id': 'int',
> >              '*socket-id': 'int',
> > +            '*die-id': 'int',
> 
> Missing documentation of the new field, including a '(since 4.0)' tag.
[Xu, Like] Let me add more docs in next version and thanks.
> 
> >              '*core-id': 'int',
> >              '*thread-id': 'int'
> >    }
> 
> 
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org