[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug.
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug. |
Date: |
Tue, 15 Jan 2019 10:27:20 +0100 |
On Thu, 10 Jan 2019 22:03:58 +0100
David Hildenbrand <address@hidden> wrote:
> Comit 2c28c490571f ("s390x/pci: let pci devices start in configured mode")
> changed the initial state of zPCI devices from ZPCI_FS_STANDBY to
> ZPCI_FS_DISABLED (a.k.a. configured). However we still only send a
> HP_EVENT_RESERVED_TO_STANDBY event to the guest, indicating a wrong
> state.
>
> Let's send a HP_EVENT_TO_CONFIGURED event instead, to match the actual
> state the device is in.
>
> This fixes hotplugged devices having to be enabled explicitly in the
> guest e.g. via echo 1 > /sys/bus/pci/slots/00000000/power.
>
> Fixes: 2c28c490571f ("s390x/pci: let pci devices start in configured mode")
> Report-by: Cornelia Huck <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> hw/s390x/s390-pci-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied.
- [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug., David Hildenbrand, 2019/01/10
- Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug., David Hildenbrand, 2019/01/11
- Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug., Cornelia Huck, 2019/01/11
- Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug., Pierre Morel, 2019/01/14
- Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug., Cornelia Huck, 2019/01/14
- Re: [Qemu-devel] [qemu-s390x] [PATCH v1] s390x/pci: Send correct event on hotplug., Collin Walling, 2019/01/14
- Re: [Qemu-devel] [qemu-s390x] [PATCH v1] s390x/pci: Send correct event on hotplug., David Hildenbrand, 2019/01/14
- Re: [Qemu-devel] [qemu-s390x] [PATCH v1] s390x/pci: Send correct event on hotplug., Cornelia Huck, 2019/01/15
Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug.,
Cornelia Huck <=