|
From: | Alberto Garcia |
Subject: | Re: [Qemu-devel] [Qemu-block] [PATCH] throttle-groups: fix restart coroutine iothread race |
Date: | Tue, 15 Jan 2019 15:49:25 +0100 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 15 Jan 2019 03:18:00 PM CET, Stefan Hajnoczi wrote: >> So if my understanding is correct QEMU can be shut down when there >> are iothreads waiting for a mutex. Is that something that we should >> be worried about? > > Nothing joins the iothreads in vl.c:main(). > > The assumption is that anything using iothreads will detach from them. > For example, the vm runstate changes during shutdown so devices can > disable the iothread code path (and this involves draining in-flight > requests). > > My fix effectively does this by waiting for in-flight throttling > restart coroutines. Yeah, it's clear in the case of your fix. Thanks! Berto
[Prev in Thread] | Current Thread | [Next in Thread] |