[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 01/37] build: actually use CONFIG_PAM
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 01/37] build: actually use CONFIG_PAM |
Date: |
Tue, 15 Jan 2019 19:02:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-15 15:10, Yang Zhong wrote:
> From: Paolo Bonzini <address@hidden>
>
> Do not link it unconditionally into all binaries.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
I think you should put your Signed-off-by below Paolo's S-o-b into this
patch, too (since you've edited it).
> ---
> default-configs/i386-softmmu.mak | 1 +
> hw/pci-host/Makefile.objs | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/i386-softmmu.mak
> b/default-configs/i386-softmmu.mak
> index 64c998c4c8..4711155a33 100644
> --- a/default-configs/i386-softmmu.mak
> +++ b/default-configs/i386-softmmu.mak
> @@ -67,3 +67,4 @@ CONFIG_I2C=y
> CONFIG_SEV=$(CONFIG_KVM)
> CONFIG_VTD=y
> CONFIG_AMD_IOMMU=y
> +CONFIG_PAM=y
> diff --git a/hw/pci-host/Makefile.objs b/hw/pci-host/Makefile.objs
> index 6d6597c065..9d7e7cd1b8 100644
> --- a/hw/pci-host/Makefile.objs
> +++ b/hw/pci-host/Makefile.objs
> @@ -1,4 +1,4 @@
> -common-obj-y += pam.o
> +common-obj-$(CONFIG_PAM) += pam.o
>
> # PPC devices
> common-obj-$(CONFIG_PREP_PCI) += prep.o
>
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-devel] [RFC PATCH v2 20/37] build: switch to Kconfig, (continued)
- [Qemu-devel] [RFC PATCH v2 18/37] hw/display: make edid configurable, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 13/37] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 22/37] hw/pci/Makefile.objs: make pcie configurable, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 12/37] hw/nios2/Makefile.objs: Conditionally build nios2, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 15/37] minikconfig: add parser skeleton, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 01/37] build: actually use CONFIG_PAM, Yang Zhong, 2019/01/15
- Re: [Qemu-devel] [RFC PATCH v2 01/37] build: actually use CONFIG_PAM,
Thomas Huth <=
- [Qemu-devel] [RFC PATCH v2 03/37] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 16/37] minikconfig: add AST, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 08/37] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 02/37] hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 04/37] hw/m68k/Makefile.objs: Conditionally build boards, Yang Zhong, 2019/01/15