Re: [Qemu-devel] [PATCH] .cirrus.yml: basic compile and test for FreeBSD

[Eric Blake]

On 1/15/19 1:02 PM, Eric Blake wrote:
> On 1/15/19 12:51 PM, Ed Maste wrote:
>> On Tue, 15 Jan 2019 at 13:42, Ed Maste <address@hidden> wrote:
>>>
>>> From: Ed Maste <address@hidden>
>>
>> I'm not sure what part of the path between `git send-email` and the
>> list moved this From: into the message body, but it's not intentional.
> 
> It doesn't hurt. 'git am' prefers the From: in the message body over the
> From: from the message headers, if the two differ, because that is the
> only way some people have to get git to record their commits correctly
> due to the list having to rewrite their headers to avoid the mail being
> rejected from over-strict SPF settings.  In your case, the two lines
> look identical (the list didn't rewrite your header From: to work around
> SPF); but it may be due to your 'git config format.from' settings.

Hmm - I wrote that they looked identical, but I was reading your reply
(where the From: matched your body), and not your original patch (where
the two differed - the header From: included a subdomain not present in
the commit authorship).  You may also want to look at 'git config
sendemail.from' and sendemail.envelopeSender configurations.

> 
>> If someone's going to pick up this patch please edit the commit
>> message.
> 
> 'git am' already does it automatically.
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature