qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH qemu] spapr: Fix fdt warnings


From: Alexey Kardashevskiy
Subject: [Qemu-devel] [PATCH qemu] spapr: Fix fdt warnings
Date: Wed, 16 Jan 2019 15:19:16 +1100

The FDT blob which the spapr machine renders at reset time produces
warnings like this:

my-181211-154309.dts: Warning (unit_address_format): Node /address@hidden unit 
name should not have leading 0s
my-181211-154309.dts: Warning (unit_address_format): Node /address@hidden unit 
name should not have leading 0s
my-181211-154309.dts: Warning (unit_address_format): Node /address@hidden unit 
name should not have leading 0s
my-181211-154309.dts: Warning (unit_address_format): Node /address@hidden unit 
name should not have leading 0s
my-181211-154309.dts: Warning (unit_address_format): Node /address@hidden unit 
name should not have leading 0s

because TARGET_FMT_lx is defined as "%016"PRIx64.

This uses simple "%lx" to suppress the warning. Since it is spapr which
is always 64bit, we assume here that hwaddr is always "long".

Signed-off-by: Alexey Kardashevskiy <address@hidden>
---
 hw/ppc/spapr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 83081de..37cdadb 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -375,7 +375,7 @@ static int spapr_populate_memory_node(void *fdt, int 
nodeid, hwaddr start,
     mem_reg_property[0] = cpu_to_be64(start);
     mem_reg_property[1] = cpu_to_be64(size);
 
-    sprintf(mem_name, "memory@" TARGET_FMT_lx, start);
+    sprintf(mem_name, "address@hidden", start);
     off = fdt_add_subnode(fdt, 0, mem_name);
     _FDT(off);
     _FDT((fdt_setprop_string(fdt, off, "device_type", "memory")));
-- 
2.17.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]