[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able

From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode
Date: Wed, 16 Jan 2019 12:47:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2019-01-16 12:43, Cédric Le Goater wrote:
> On 1/11/19 9:17 AM, Thomas Huth wrote:
>> When compiling the ppc code with clang and -std=gnu99, there are a
>> couple of warnings/errors like this one:
>>   CC      ppc64-softmmu/hw/intc/xics.o
>> In file included from hw/intc/xics.c:35:
>> include/hw/ppc/xics.h:43:25: error: redefinition of typedef 'ICPState' is a 
>> C11 feature
>>       [-Werror,-Wtypedef-redefinition]
>> typedef struct ICPState ICPState;
>>                         ^
>> target/ppc/cpu.h:1181:25: note: previous definition is here
>> typedef struct ICPState ICPState;
>>                         ^
>> Work around the problems by including the proper headers instead.
> Thomas,
> After a closer look, I think we should use 'void *' under PowerPCCPU 
> as it was the case before I introduced the second interrupt presenter.

If you don't like the #includes, why not simply do anonymous struct
forward declarations here? I think that would be better than "void *".

> That's a bigger change reverting bits of already merged patches. I can
> take care of it if you prefer. 

Could I keep the current patch in my series so that I can get the
patches finally merged? You could then do any clean up that you like on
top of it, ok?

> I use a f29 for dev. Which compiler should I install ? 

Any version of Clang with -std=gnu99 should do the job here, I think.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]