[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] block: Eliminate the S_1KiB, S

From: Alberto Garcia
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] block: Eliminate the S_1KiB, S_2KiB, ... macros
Date: Wed, 16 Jan 2019 13:57:26 +0100
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Fri 11 Jan 2019 08:14:01 PM CET, Markus Armbruster wrote:
> We define 54 macros for the powers of two >= 1024.  We use six, in six
> macro definitions.  Four of them could just as well use the common MiB
> macro, so do that.  The remaining two can't, because they get passed
> to stringify.  Replace the macro by the literal number there.
> Slightly harder to read in one instance (1048576 vs. S_1MiB), so add a
> comment there.  The other instance is a wash: 65536 vs S_64KiB.  65536
> has been good enough for more than seven years there.
> This effectively reverts commit 540b8492618 and 1240ac558d3.
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Alberto Garcia <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]