[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 02/10] block/nbd: move connection code from b
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 02/10] block/nbd: move connection code from block/nbd to block/nbd-client |
Date: |
Wed, 16 Jan 2019 09:56:15 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 7/31/18 12:30 PM, Vladimir Sementsov-Ogievskiy wrote:
> Keep all connection code in one file, to be able to implement reconnect
> in further patches.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/nbd-client.h | 2 +-
> block/nbd-client.c | 37 +++++++++++++++++++++++++++++++++++--
> block/nbd.c | 40 ++--------------------------------------
> 3 files changed, 38 insertions(+), 41 deletions(-)
>
> @@ -1001,12 +1033,14 @@ int nbd_client_init(BlockDriverState *bs,
> g_free(client->info.x_dirty_bitmap);
> if (ret < 0) {
> logout("Failed to negotiate with the NBD server\n");
> + object_unref(OBJECT(sioc));
> return ret;
> }
> if (client->info.flags & NBD_FLAG_READ_ONLY &&
> !bdrv_is_read_only(bs)) {
> error_setg(errp,
> "request for write access conflicts with read-only
> export");
> + object_unref(OBJECT(sioc));
> return -EACCES;
> }
Conflicts with changes committed in the meantime. I think I can resolve
the conflicts, but you may want to post a v5.
The patch itself looks reasonable;
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 02/10] block/nbd: move connection code from block/nbd to block/nbd-client,
Eric Blake <=