[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 47/50] paaudio: channel-map option
From: |
Kővágó, Zoltán |
Subject: |
[Qemu-devel] [PATCH v3 47/50] paaudio: channel-map option |
Date: |
Thu, 17 Jan 2019 00:37:20 +0100 |
Add an option to change the channel map used by pulseaudio. If not
specified, falls back to an OSS compatible channel map.
Signed-off-by: Kővágó, Zoltán <address@hidden>
---
qapi/audio.json | 5 ++++-
audio/paaudio.c | 18 ++++++++++++++----
qemu-options.hx | 9 +++++++++
3 files changed, 27 insertions(+), 5 deletions(-)
diff --git a/qapi/audio.json b/qapi/audio.json
index 7bcea6240f..86078039dc 100644
--- a/qapi/audio.json
+++ b/qapi/audio.json
@@ -107,11 +107,14 @@
#
# @name: name of the sink/source to use
#
+# @channel-map: channel map to use (default: OSS compatible map)
+#
# Since: 4.0
##
{ 'struct': 'AudiodevPaPerDirectionOptions',
'data': {
- '*name': 'str' } }
+ '*name': 'str',
+ '*channel-map': 'str' } }
##
# @AudiodevPaOptions:
diff --git a/audio/paaudio.c b/audio/paaudio.c
index 0d67c03b4c..b0e311584a 100644
--- a/audio/paaudio.c
+++ b/audio/paaudio.c
@@ -337,17 +337,27 @@ static pa_stream *qpa_simple_new (
pa_stream_direction_t dir,
const char *dev,
const pa_sample_spec *ss,
- const pa_channel_map *map,
+ const char *map,
const pa_buffer_attr *attr,
int *rerror)
{
int r;
pa_stream *stream;
pa_stream_flags_t flags;
+ pa_channel_map pa_map;
pa_threaded_mainloop_lock(c->mainloop);
- stream = pa_stream_new(c->context, name, ss, map);
+ if (map && !pa_channel_map_parse(&pa_map, map)) {
+ dolog("Invalid channel map specified: '%s'\n", map);
+ map = NULL;
+ }
+ if (!map) {
+ pa_channel_map_init_extend(&pa_map, ss->channels,
+ PA_CHANNEL_MAP_OSS);
+ }
+
+ stream = pa_stream_new(c->context, name, ss, &pa_map);
if (!stream) {
goto fail;
}
@@ -424,7 +434,7 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsettings
*as,
PA_STREAM_PLAYBACK,
ppdo->has_name ? ppdo->name : NULL,
&ss,
- NULL, /* channel map */
+ ppdo->has_channel_map ? ppdo->channel_map : NULL,
&ba, /* buffering attributes */
&error
);
@@ -472,7 +482,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettings
*as, void *drv_opaque)
PA_STREAM_RECORD,
ppdo->has_name ? ppdo->name : NULL,
&ss,
- NULL, /* channel map */
+ ppdo->has_channel_map ? ppdo->channel_map : NULL,
NULL, /* buffering attributes */
&error
);
diff --git a/qemu-options.hx b/qemu-options.hx
index 53fc5ef453..c4835f77c3 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -468,6 +468,7 @@ DEF("audiodev", HAS_ARG, QEMU_OPTION_audiodev,
"-audiodev pa,id=id[,prop[=value][,...]]\n"
" server= PulseAudio server address\n"
" sink|source.name= sink/source device name\n"
+ " sink|source.channel-map= channel map to use\n"
#endif
#ifdef CONFIG_SDL
"-audiodev sdl,id=id[,prop[=value][,...]]\n"
@@ -621,6 +622,14 @@ Sets the PulseAudio @var{server} to connect to.
@item sink|address@hidden
Use the specified sink/source for playback/recording.
address@hidden sink|address@hidden
+Use the specified channel map. The default is an OSS compatible
+channel map. Do not forget to escape commas inside the map:
+
address@hidden
+-audiodev pa,id=example,sink.channel-map=front-left,,front-right
address@hidden example
+
@end table
@item -audiodev sdl,address@hidden,@address@hidden,...]]
--
2.20.1
- [Qemu-devel] [PATCH v3 37/50] audio: unify input and output mixeng buffer management, (continued)
- [Qemu-devel] [PATCH v3 37/50] audio: unify input and output mixeng buffer management, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 33/50] sdlaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 26/50] audio: api for mixeng code free backends, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 48/50] usb-audio: do not count on avail bytes actually available, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 41/50] audio: add mixeng option (documentation), Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 27/50] alsaaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 40/50] audio: split ctl_* functions into enable_* and volume_*, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 34/50] spiceaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 42/50] audio: make mixeng optional, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 47/50] paaudio: channel-map option,
Kővágó, Zoltán <=
- [Qemu-devel] [PATCH v3 29/50] dsoundaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 31/50] ossaudio: port to the new audio backend api, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 25/50] audio: use size_t where makes sense, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 50/50] usbaudio: change playback counters to 64 bit, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 38/50] audio: remove hw->samples, buffer_size_in/out pcm_ops, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 39/50] audio: common rate control code for timer based outputs, Kővágó, Zoltán, 2019/01/16