[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/7] fp-bench: fix update_random_ops
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 1/7] fp-bench: fix update_random_ops |
Date: |
Thu, 17 Jan 2019 13:26:57 +0000 |
From: "Emilio G. Cota" <address@hidden>
The second test in the branches is wrong; fix while converting
to a switch statement, which is easier to get right.
Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
diff --git a/tests/fp/fp-bench.c b/tests/fp/fp-bench.c
index f5bc5edebf..546bac9c9c 100644
--- a/tests/fp/fp-bench.c
+++ b/tests/fp/fp-bench.c
@@ -143,15 +143,20 @@ static void update_random_ops(int n_ops, enum precision
prec)
for (i = 0; i < n_ops; i++) {
uint64_t r = random_ops[i];
- if (prec == PREC_SINGLE || PREC_FLOAT32) {
+ switch (prec) {
+ case PREC_SINGLE:
+ case PREC_FLOAT32:
do {
r = xorshift64star(r);
} while (!float32_is_normal(r));
- } else if (prec == PREC_DOUBLE || PREC_FLOAT64) {
+ break;
+ case PREC_DOUBLE:
+ case PREC_FLOAT64:
do {
r = xorshift64star(r);
} while (!float64_is_normal(r));
- } else {
+ break;
+ default:
g_assert_not_reached();
}
random_ops[i] = r;
--
2.17.1
- [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 7/7] tests/Makfile: add check-softfloat rule, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 5/7] tests/Makefile: add floating point tests, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 4/7] include/fpu/softfloat: Fix compilation with Clang on s390x, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 3/7] softfloat: enforce softfloat if the host's FMA is broken, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 6/7] scripts/archive-source: include softfloat tests, Alex Bennée, 2019/01/17
- [Qemu-devel] [PULL 1/7] fp-bench: fix update_random_ops,
Alex Bennée <=
- [Qemu-devel] [PULL 2/7] fp-bench: remove wrong exponent raise in fill_random, Alex Bennée, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Peter Maydell, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Emilio G. Cota, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Peter Maydell, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Emilio G. Cota, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Alex Bennée, 2019/01/18
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Peter Maydell, 2019/01/18
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Emilio G. Cota, 2019/01/18
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Alex Bennée, 2019/01/17
- Re: [Qemu-devel] [PULL 0/7] check-softfloat, fp-bench and clang compile fixes, Philippe Mathieu-Daudé, 2019/01/18