[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/13] block: Freeze the backing chain for the durat
From: |
Alberto Garcia |
Subject: |
[Qemu-devel] [PATCH 04/13] block: Freeze the backing chain for the duration of the stream job |
Date: |
Thu, 17 Jan 2019 17:33:55 +0200 |
Signed-off-by: Alberto Garcia <address@hidden>
---
block/stream.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/block/stream.c b/block/stream.c
index 7a49ac0992..39a2e10892 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -54,6 +54,14 @@ static int coroutine_fn stream_populate(BlockBackend *blk,
return blk_co_preadv(blk, offset, qiov.size, &qiov, BDRV_REQ_COPY_ON_READ);
}
+static void stream_abort(Job *job)
+{
+ StreamBlockJob *s = container_of(job, StreamBlockJob, common.job);
+ BlockJob *bjob = &s->common;
+
+ bdrv_unfreeze_backing_chain(blk_bs(bjob->blk), s->base);
+}
+
static int stream_prepare(Job *job)
{
StreamBlockJob *s = container_of(job, StreamBlockJob, common.job);
@@ -63,6 +71,8 @@ static int stream_prepare(Job *job)
Error *local_err = NULL;
int ret = 0;
+ bdrv_unfreeze_backing_chain(bs, base);
+
if (bs->backing) {
const char *base_id = NULL, *base_fmt = NULL;
if (base) {
@@ -213,6 +223,7 @@ static const BlockJobDriver stream_job_driver = {
.free = block_job_free,
.run = stream_run,
.prepare = stream_prepare,
+ .abort = stream_abort,
.clean = stream_clean,
.user_resume = block_job_user_resume,
.drain = block_job_drain,
@@ -259,6 +270,11 @@ void stream_start(const char *job_id, BlockDriverState *bs,
&error_abort);
}
+ if (bdrv_freeze_backing_chain(bs, base, errp) < 0) {
+ job_early_fail(&s->common.job);
+ goto fail;
+ }
+
s->base = base;
s->backing_file_str = g_strdup(backing_file_str);
s->bs_read_only = bs_read_only;
--
2.11.0
- [Qemu-devel] [PATCH 00/13] Add a 'x-blockdev-reopen' QMP command, Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 04/13] block: Freeze the backing chain for the duration of the stream job,
Alberto Garcia <=
- [Qemu-devel] [PATCH 11/13] block: Remove the AioContext parameter from bdrv_reopen_multiple(), Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 03/13] block: Freeze the backing chain for the duration of the mirror job, Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 07/13] block: Allow omitting the 'backing' option in certain cases, Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 10/13] block: Add bdrv_reset_options_allowed(), Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 08/13] block: Allow changing the backing file on reopen, Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 02/13] block: Freeze the backing chain for the duration of the commit job, Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 01/13] block: Allow freezing BdrvChild links, Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 06/13] block: Handle child references in bdrv_reopen_queue(), Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 12/13] block: Add an 'x-blockdev-reopen' QMP command, Alberto Garcia, 2019/01/17
- [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver, Alberto Garcia, 2019/01/17