[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/3] Expand 'qemu-img info' to show protocol
Re: [Qemu-devel] [RFC PATCH 0/3] Expand 'qemu-img info' to show protocol details
Thu, 17 Jan 2019 10:15:22 -0600
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
On 1/17/19 10:06 AM, Daniel P. Berrangé wrote:
> One thing that occurs to me is that the qemu-img info output data is
> getting larger & larger over time. Especially with LUKS, the format
> specific data is quite huge. Adding protocol specific info makes it
> larger again.
> In retrospect, IMHO, it would have been nice to not show the format
> specific info by default, requiring a --verbose arg. Assuming we don't
> want to change default behaviour though, we might as well show protocol
> specific info by default too.
> I wonder though if we could benefit from a '-b' / '--brief' arg to make
> it switch to show only the short common metadata, for people who want a
> more concise output.
Do we have any backwards-compatibility guarantees on the output? The
--output=json is obviously going to be verbose, no matter what. But that
argues that any machine parsing should use --output=json, and that
--output=human can change without regards to back-compat. Or, we could
have --output=brief as a new third ofmt option (without having to burn
-b), and/or make --output=full be the verbose human form, and let the
default --output=human stick to brief by default.
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Description: OpenPGP digital signature