[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 3/3] tests/microbit-test: Check nRF51 UART fu

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v4 3/3] tests/microbit-test: Check nRF51 UART functionality
Date: Thu, 17 Jan 2019 17:41:09 +0000
User-agent: Mutt/1.10.1 (2018-07-13)

On Thu, Jan 17, 2019 at 07:16:40PM +0300, Julia Suvorova wrote:
> diff --git a/tests/microbit-test.c b/tests/microbit-test.c
> index afeb6b082a..3da6d9529f 100644
> --- a/tests/microbit-test.c
> +++ b/tests/microbit-test.c
> @@ -19,10 +19,93 @@
>  #include "libqtest.h"
>  #include "hw/arm/nrf51.h"
> +#include "hw/char/nrf51_uart.h"
>  #include "hw/gpio/nrf51_gpio.h"
>  #include "hw/timer/nrf51_timer.h"
>  #include "hw/i2c/microbit_i2c.h"
> +#include <sys/socket.h>
> +#include <sys/un.h>

./HACKING "1.2. Include directives" requires putting system header
includes (<>) right after #include "qemu/osdep.h".

But are these includes really needed?  This code doesn't use Sockets API
calls like send(2)/recv(2)/shutdown(2) or UNIX Domain Sockets specifics
like struct sockaddr_un.

I suggest dropping these includes (plus they are pulled in implicitly by
osdep.h anyway).

Peter: If there are no other issues with this patch series, could you
remove these two includes when merging?  Thanks!

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]