[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Add a proper check for openpty() in
Re: [Qemu-devel] [PATCH] configure: Add a proper check for openpty() in libutil
Thu, 17 Jan 2019 18:07:34 +0000
On Thu, 17 Jan 2019 at 17:14, Thomas Huth <address@hidden> wrote:
> On Linux (and maybe some BSDs), we require libutil for the openpty()
> function. However, this library is not available on some other systems, so
> we currently use a fragile if-statement in the configure script to check
> whether we need the library or not. Unfortunately, we also hard-coded a
> "-lutil" in the tests/Makefile.include file, so this breaks the build on
> Solaris, for example (see buglink below). To fix the issue, add the "-lutil"
> to "libs_tools" in the configure script instead, then this gets properly
> propagated to the tests, too.
It also gets propagated to every tool binary we build even if
it doesn't use openpty(), but I guess that's not a big deal.