qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL v2 00/49] pci, pc, virtio: fixes, features


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PULL v2 00/49] pci, pc, virtio: fixes, features
Date: Thu, 17 Jan 2019 21:12:53 -0500

On Thu, Jan 17, 2019 at 04:21:24PM +0000, Peter Maydell wrote:
> On Thu, 17 Jan 2019 at 13:44, Michael S. Tsirkin <address@hidden> wrote:
> >
> > On Thu, Jan 17, 2019 at 12:48:22PM +0000, Peter Maydell wrote:
> > > This fails 'make check' on s390x host:
> 
> > Oh. I am pretty sure it's endian-ness :(
> >
> > Any chance you can quickly test the below?
> 
> Yes, that change allows the tests to pass on the s390 box.
> 
> thanks
> -- PMM

Re-pushed a fixed patch to the same tag.

Igor, in the future pls remember to be conscious of size of integers:
it's not safe to cast uint32_t* to gsize *!

Thanks!

-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]