[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/27] slirp: generalize guestfwd with a callbac
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/27] slirp: generalize guestfwd with a callback based approach |
|
Date: |
Fri, 18 Jan 2019 15:04:59 +0400 |
Hi
On Fri, Jan 18, 2019 at 3:07 AM Samuel Thibault <address@hidden> wrote:
>
> Marc-André Lureau, le jeu. 17 janv. 2019 15:43:33 +0400, a ecrit:
> > /* XXX this blocks entire thread. Rewrite to use
> > * qemu_chr_fe_write and background I/O callbacks */
>
> Seeing this, I guess a whole pass will be useful to turn these qemu
> comment references into something that does not require knowledge of
> qemu internals :)
Sure, we will have to do some doc/comments update. I can look at it.
That's not a blocker imho.
thanks
--
Marc-André Lureau
- [Qemu-devel] [PATCH 00/27] slirp: make it again a standalone project (part 2), Marc-André Lureau, 2019/01/17
- [Qemu-devel] [PATCH 01/27] slirp: generalize guestfwd with a callback based approach, Marc-André Lureau, 2019/01/17
- [Qemu-devel] [PATCH 02/27] net/slirp: simplify checking for cmd: prefix, Marc-André Lureau, 2019/01/17
- [Qemu-devel] [PATCH 04/27] net/slirp: fix leaks on forwaring rule registration error, Marc-André Lureau, 2019/01/17
- [Qemu-devel] [PATCH 03/27] net/slirp: free forwarding rules on cleanup, Marc-André Lureau, 2019/01/17
- [Qemu-devel] [PATCH 05/27] slirp: add callbacks for timer, Marc-André Lureau, 2019/01/17