[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/11] s390x/pci: Use hotplug_dev instead of looking
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 07/11] s390x/pci: Use hotplug_dev instead of looking up the host bridge |
Date: |
Fri, 18 Jan 2019 13:19:21 +0100 |
From: David Hildenbrand <address@hidden>
We directly have it in our hands.
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Collin Walling <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/s390x/s390-pci-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 400d9e4f28..248e0eb295 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -826,9 +826,9 @@ static bool s390_pci_alloc_idx(S390pciState *s,
S390PCIBusDevice *pbdev)
static void s390_pcihost_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
Error **errp)
{
+ S390pciState *s = S390_PCI_HOST_BRIDGE(hotplug_dev);
PCIDevice *pdev = NULL;
S390PCIBusDevice *pbdev = NULL;
- S390pciState *s = s390_get_phb();
if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_BRIDGE)) {
BusState *bus;
@@ -937,11 +937,11 @@ static void s390_pcihost_timer_cb(void *opaque)
static void s390_pcihost_unplug(HotplugHandler *hotplug_dev, DeviceState *dev,
Error **errp)
{
+ S390pciState *s = S390_PCI_HOST_BRIDGE(hotplug_dev);
PCIDevice *pci_dev = NULL;
PCIBus *bus;
int32_t devfn;
S390PCIBusDevice *pbdev = NULL;
- S390pciState *s = s390_get_phb();
if (object_dynamic_cast(OBJECT(dev), TYPE_PCI_BRIDGE)) {
error_setg(errp, "PCI bridge hot unplug currently not supported");
--
2.17.2
- [Qemu-devel] [PULL 00/11] s390x updates, Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 01/11] s390: avoid potential null dereference in s390_pcihost_unplug(), Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 04/11] configure: Only build the s390-ccw bios if the compiler supports -march=z900, Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 03/11] s390x: Return specification exception for unimplemented diag 308 subcodes, Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 02/11] pc-bios/s390-ccw: Use proper register names for Clang, Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 05/11] s390x/pci: Send correct event on hotplug, Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 06/11] s390x/pci: Set the iommu region size mpcifc request, Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 07/11] s390x/pci: Use hotplug_dev instead of looking up the host bridge,
Cornelia Huck <=
- [Qemu-devel] [PULL 08/11] s390x/pci: Move some hotplug checks to the pre_plug handler, Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 09/11] s390x/pci: Always delete and free the release_timer, Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 11/11] s390x/pci: add common function measurement block, Cornelia Huck, 2019/01/18
- [Qemu-devel] [PULL 10/11] s390x/pci: Ignore the unplug call if we already have a release_timer, Cornelia Huck, 2019/01/18
- Re: [Qemu-devel] [PULL 00/11] s390x updates, Peter Maydell, 2019/01/18