Re: [Qemu-devel] [PATCH 2/5] tests/libqos: rename qpci_init_pc and qpci_init_spapr functions

[Paolo Bonzini]

On 18/01/19 13:23, Thomas Huth wrote:
>> diff --git a/tests/libqos/pci-pc.h b/tests/libqos/pci-pc.h
>> index 491eeac..84cc300 100644
>> --- a/tests/libqos/pci-pc.h
>> +++ b/tests/libqos/pci-pc.h
>> @@ -16,7 +16,14 @@
>>  #include "libqos/pci.h"
>>  #include "libqos/malloc.h"
>>  
>> -QPCIBus *qpci_init_pc(QTestState *qts, QGuestAllocator *alloc);
>> +/* qpci_new_pc():
>> +* this function creates a new QPCIBusPC object,
> 
> Hmm, you did not notice my previous review, did you? See:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01417.html

No, I missed it.

> I'd also be fine if we keep "init" instead
> of "new"... it's quite a bit of code churn ...

It matches QOM's object_new vs. object_initialize.

Paolo