[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom |
Date: |
Fri, 18 Jan 2019 15:33:16 -0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Tue, Jan 15, 2019 at 01:57:22PM -0500, Michael S. Tsirkin wrote:
> On Tue, Jan 15, 2019 at 11:00:58AM +0100, Stefano Garzarella wrote:
> > Use pvh.bin option rom when we are booting an uncompressed
> > kernel using the x86/HVM direct boot ABI.
> >
> > Signed-off-by: Stefano Garzarella <address@hidden>
> > Based-on: <address@hidden>
>
> I don't think this is a great way to give attribution.
> Can you pls include the author name and the S.O.B from there as well?
>
>
> > ---
> > hw/i386/pc.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index 06bce6a101..7564ba51d2 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -1005,6 +1005,10 @@ static void load_linux(PCMachineState *pcms,
> > fw_cfg_add_bytes(fw_cfg, FW_CFG_SETUP_DATA,
> > header, sizeof(header));
> >
> > + option_rom[nb_option_roms].bootindex = 0;
> > + option_rom[nb_option_roms].name = "pvh.bin";
> > + nb_option_roms++;
> > +
> > return;
> > }
> > /* This looks like a multiboot kernel. If it is, let's stop
> > @@ -1456,6 +1460,7 @@ void xen_load_linux(PCMachineState *pcms)
> > for (i = 0; i < nb_option_roms; i++) {
> > assert(!strcmp(option_rom[i].name, "linuxboot.bin") ||
> > !strcmp(option_rom[i].name, "linuxboot_dma.bin") ||
> > + !strcmp(option_rom[i].name, "pvh.bin") ||
> > !strcmp(option_rom[i].name, "multiboot.bin"));
> > rom_add_option(option_rom[i].name, option_rom[i].bootindex);
> > }
>
> OK but this is guest visible so needs to be guarded by the
> new machine type.
Aren't option ROMs treated like other firmware? i.e.: guest
visible, but copied during live migration and not considered part
of guest ABI.
--
Eduardo
[Qemu-devel] [PATCH v2 3/4] optionrom: add new PVH option rom, Stefano Garzarella, 2019/01/15
[Qemu-devel] [PATCH v2 1/4] linuxboot_dma: remove duplicate definitions of FW_CFG, Stefano Garzarella, 2019/01/15
[Qemu-devel] [PATCH v2 2/4] linuxboot_dma: move common functions in a new header, Stefano Garzarella, 2019/01/15
Re: [Qemu-devel] [PATCH v2 0/4] pvh: add new PVH option rom, Stefan Hajnoczi, 2019/01/15
Re: [Qemu-devel] [PATCH v2 0/4] pvh: add new PVH option rom, Liam Merwick, 2019/01/16