[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH PULL 04/10] hw/pvrdma: Post CQE when receive invalid
From: |
Marcel Apfelbaum |
Subject: |
[Qemu-devel] [PATCH PULL 04/10] hw/pvrdma: Post CQE when receive invalid gid index |
Date: |
Sat, 19 Jan 2019 12:03:09 +0200 |
From: Yuval Shaia <address@hidden>
This error should propagate back to guest.
Spotted by Coverity: CID 1398595
Fixes: 2b05705dc8
Reported-by: Li Qiang <address@hidden>
Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
---
hw/rdma/rdma_backend.h | 1 +
hw/rdma/vmw/pvrdma_qp_ops.c | 6 ++++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h
index a9ba40ae48..5114c90e67 100644
--- a/hw/rdma/rdma_backend.h
+++ b/hw/rdma/rdma_backend.h
@@ -32,6 +32,7 @@
#define VENDOR_ERR_INVLKEY 0x207
#define VENDOR_ERR_MR_SMALL 0x208
#define VENDOR_ERR_INV_MAD_BUFF 0x209
+#define VENDOR_ERR_INV_GID_IDX 0x210
/* Add definition for QP0 and QP1 as there is no userspace enums for them */
enum ibv_special_qp_type {
diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
index 465bee8641..0565eba981 100644
--- a/hw/rdma/vmw/pvrdma_qp_ops.c
+++ b/hw/rdma/vmw/pvrdma_qp_ops.c
@@ -178,7 +178,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
sgid = rdma_rm_get_gid(&dev->rdma_dev_res,
wqe->hdr.wr.ud.av.gid_index);
if (!sgid) {
pr_dbg("Fail to get gid for idx %d\n",
wqe->hdr.wr.ud.av.gid_index);
- return -EIO;
+ complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx);
+ continue;
}
pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index,
sgid->global.interface_id);
@@ -189,7 +190,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
if (sgid_idx <= 0) {
pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n",
wqe->hdr.wr.ud.av.gid_index);
- return -EIO;
+ complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx);
+ continue;
}
if (wqe->hdr.num_sge > dev->dev_attr.max_sge) {
--
2.17.1
- [Qemu-devel] [PATCH PULL 00/10] RDMA queue, Marcel Apfelbaum, 2019/01/19
- [Qemu-devel] [PATCH PULL 01/10] docs/pvrdma: Update rdmacm-mux documentation, Marcel Apfelbaum, 2019/01/19
- [Qemu-devel] [PATCH PULL 09/10] hw/rdma: modify struct initialization, Marcel Apfelbaum, 2019/01/19
- [Qemu-devel] [PATCH PULL 05/10] hw/pvrdma: Make function pvrdma_qp_send/recv return void., Marcel Apfelbaum, 2019/01/19
- [Qemu-devel] [PATCH PULL 07/10] hw: rdma: fix an off-by-one issue, Marcel Apfelbaum, 2019/01/19
- [Qemu-devel] [PATCH PULL 08/10] contrib/rdmacm-mux: remove Wno-format-truncation flag, Marcel Apfelbaum, 2019/01/19
- [Qemu-devel] [PATCH PULL 06/10] hw/rdma: Verify that ptr is not NULL before freeing, Marcel Apfelbaum, 2019/01/19
- [Qemu-devel] [PATCH PULL 04/10] hw/pvrdma: Post CQE when receive invalid gid index,
Marcel Apfelbaum <=
- [Qemu-devel] [PATCH PULL 03/10] hw/rdma: Delete unused struct member, Marcel Apfelbaum, 2019/01/19
- [Qemu-devel] [PATCH PULL 02/10] hw/pvrdma: Remove max-sge command-line param, Marcel Apfelbaum, 2019/01/19
- [Qemu-devel] [PATCH PULL 10/10] contrib/rdmacm-mux: fix clang compilation, Marcel Apfelbaum, 2019/01/19
- Re: [Qemu-devel] [PATCH PULL 00/10] RDMA queue, 李强, 2019/01/20
- Re: [Qemu-devel] [PATCH PULL 00/10] RDMA queue, Peter Maydell, 2019/01/22