Re: [Qemu-devel] [PATCH v4 26/35] target/riscv: Remove shift and slt insn manual decoding

[Richard Henderson]

On 1/19/19 12:14 AM, Bastian Koppelmann wrote:
> Signed-off-by: Bastian Koppelmann <address@hidden>
> Signed-off-by: Peer Adelt <address@hidden>
> ---
> v3 -> v4:
>     - refactor tcg_gen_set_cond_tl(TCG_COND_LT,..) into gen_slt function
>       and reuse gen_arith(..., &gen_slt) for all trans_slt functions.
>     - Add missing sign extension to trans_srlw/sllw
>     - Made rs2 == 0 a special case of srlw/sllw

Why?  It's not like it is a likely case, and it works without.

That said,

> 
>  target/riscv/insn_trans/trans_rvi.inc.c | 98 +++++++++++++++++--------
>  target/riscv/translate.c                | 59 +++++----------
>  2 files changed, 86 insertions(+), 71 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~