[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] trace: add ability to do simple printf l
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] trace: add ability to do simple printf logging via systemtap |
Date: |
Mon, 21 Jan 2019 10:53:14 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Jan 18, 2019 at 12:14:14PM -0600, Eric Blake wrote:
> On 1/18/19 11:31 AM, Daniel P. Berrangé wrote:
> > +def c_macro_to_format(macro):
> > + if macro.startswith("PRI"):
> > + return macro[3]
> > +
> > + if macro == "TARGET_FMT_plx":
> > + return "%016x"
>
> Do we really want to permit TARGET_FMT in our trace-events files, or
> should that be fixed in hw/tpm/trace-events? See commit 73ff0610.
TARGET_FMT_plx is constant across all QEMU targets. I think supporting
it is nice since it makes writing trace events more natural/convenient.
Stefan
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v2 2/4] trace: enforce that every trace-events file has a final newline, (continued)
- [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings, Daniel P . Berrangé, 2019/01/18
- Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings, Eric Blake, 2019/01/18
- Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings, Alex Williamson, 2019/01/18
- Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings, Daniel P . Berrangé, 2019/01/22
- Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings, Eric Blake, 2019/01/22
- Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings, Daniel P . Berrangé, 2019/01/22
- Re: [Qemu-devel] [PATCH v2 3/4] trace: forbid use of %m in trace event format strings, Eric Blake, 2019/01/22
[Qemu-devel] [PATCH v2 4/4] trace: add ability to do simple printf logging via systemtap, Daniel P . Berrangé, 2019/01/18