qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 0/8] Bitmaps patches


From: Daniel P . Berrangé
Subject: Re: [Qemu-devel] [PULL 0/8] Bitmaps patches
Date: Mon, 21 Jan 2019 12:40:45 +0000
User-agent: Mutt/1.10.1 (2018-07-13)

On Mon, Jan 21, 2019 at 01:21:34PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/21/19 8:54 AM, address@hidden wrote:
> > Patchew URL: https://patchew.org/QEMU/address@hidden/
> > 
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> > time make address@hidden SHOW_ENV=1 J=14
> > === TEST SCRIPT END ===
> > 
> >   CC      crypto/block.o
> >   CC      crypto/block-qcow.o
> > /tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':
> > /tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified 
> > bound 256 equals destination size [-Werror=stringop-truncation]
> >      strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
> >      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> 
> Thanks Patchew, this error is now fixed (merged in 51c1c135608).

patchew's build test queue seems to running about 5 days slow, but its
git apply queue is timely. So it is testing this patch using git head
as of 5 days ago, despite the build only running today.

So I presume the fix in 51c1c135608 will only start to have effect for
patches that patchew imported to git after 51c1c135608 merged.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]