Re: [Qemu-devel] [Qemu-arm] [PATCH] target/arm: v8m: Ensure IDAU is respected if SAU is disabled

[Peter Maydell]

On Sun, 20 Jan 2019 at 14:51, Thomas Roth <address@hidden> wrote:
>
> The current behavior of v8m_security_lookup in helper.c only checks whether 
> the
> IDAU specifies a higher security if the SAU is enabled. If SAU.ALLNS is set to
> 1, this will lead to addresses being treated as non-secure, even though the
> IDAU indicates that they must be secure.
>
> This patch changes the behavior to also check the IDAU if the SAU is currently
> disabled.
>
> Signed-off-by: Thomas Roth <address@hidden>

Oops, yes. In the v8M Arm ARM the pseudocode function for this
is SecurityCheck(), and we should indeed not ignore the IDAU for
the SAU disabled path.

Applied to target-arm.next, thanks. (I'll tweak the commit message
to add the Arm ARM reference and make the block comment follow
our current coding style, since we're moving it anyway.)

thanks
-- PMM