[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/18] Acceptance tests: improve docstring on pi
From: |
Caio Carrara |
Subject: |
Re: [Qemu-devel] [PATCH 03/18] Acceptance tests: improve docstring on pick_default_qemu_bin() |
Date: |
Mon, 21 Jan 2019 18:20:47 -0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Jan 17, 2019 at 01:56:13PM -0500, Cleber Rosa wrote:
> Making it clear what is returned by this utility function.
>
> Signed-off-by: Cleber Rosa <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Caio Carrara <address@hidden>
> ---
> tests/acceptance/avocado_qemu/__init__.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py
> b/tests/acceptance/avocado_qemu/__init__.py
> index 1e54fd5932..d8d5b48dac 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -27,6 +27,10 @@ def pick_default_qemu_bin():
> """
> Picks the path of a QEMU binary, starting either in the current working
> directory or in the source tree root directory.
> +
> + :returns: the path to the default QEMU binary or None if one could not
> + be found
> + :rtype: str or None
> """
> arch = os.uname()[4]
> qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
> --
> 2.20.1
>
--
Caio Carrara
Software Engineer, Virt Team - Red Hat
address@hidden
- [Qemu-devel] [PATCH 05/18] Acceptance tests: introduce arch parameter and attribute, (continued)
- [Qemu-devel] [PATCH 05/18] Acceptance tests: introduce arch parameter and attribute, Cleber Rosa, 2019/01/17
- [Qemu-devel] [PATCH 15/18] Boot Linux Console Test: add a test for aarch64 + virt, Cleber Rosa, 2019/01/17
- [Qemu-devel] [PATCH 03/18] Acceptance tests: improve docstring on pick_default_qemu_bin(), Cleber Rosa, 2019/01/17
- Re: [Qemu-devel] [PATCH 03/18] Acceptance tests: improve docstring on pick_default_qemu_bin(),
Caio Carrara <=
- [Qemu-devel] [PATCH 10/18] Boot Linux Console Test: refactor the console watcher into utility method, Cleber Rosa, 2019/01/17
- [Qemu-devel] [PATCH 08/18] Boot Linux Console Test: rename the x86_64 after the arch and machine, Cleber Rosa, 2019/01/17
- [Qemu-devel] [PATCH 14/18] Boot Linux Console Test: add a test for ppc64 + pseries, Cleber Rosa, 2019/01/17